Thing add page: Add support for optional scan input #2771
Conversation
Refs openhab/openhab-core#4389. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
#2283 Bundle Size — 10.82MiB (+0.01%).1de9695(current) vs 217fc06 main#2280(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2283 |
Baseline #2280 |
|
|---|---|---|
 Initial JS |
1.89MiB |
1.89MiB |
| Initial CSS |
576.5KiB |
576.5KiB |
 Cache Invalidation |
18.15% |
0.01% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2920 |
2920 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #2283 |
Baseline #2280 |
|
|---|---|---|
| JS |
9.04MiB (+0.01%) |
9.04MiB |
| CSS |
863.22KiB |
863.22KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.39KiB |
1.39KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:thing-add-scaninput Project dashboard
Generated by RelativeCI Documentation Report issue
|
Tested and it works exactly as we expected. Top. @digitaldan you can now rely on this new feature and remove pairing code as thing configuration and as thing channel. @florian-h05 I just saw a little bug in rendering with a text almost hidden: |
|
@lolodomo Thanks for noticing … this is cause by a „quick-and-dirty“ style fix I used, I should probably do it the clean way now. |
Follow-up for openhab#2771. Fixes openhab#2771 (comment). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Follow-up for #2771. Fixes #2771 (comment). Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@florian-h05 : final step would be to also propose to scan a QR code. Is there something like that in "HTML" standard ? |
|
I have already played around with QR code scanners in the browser in a little side project … so it is possible. These pairing code QR codes only contain the pairing code itself or additional data? |
Refs openhab/openhab-core#4389.