Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dirty indicator on the title bar #2687

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Add a dirty indicator on the title bar #2687

merged 2 commits into from
Aug 4, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jul 26, 2024 •
edited
Loading

image

@jimtng jimtng requested a review from a team as a code owner July 26, 2024 08:04
@jimtng jimtng force-pushed the dirty-indicator branch 2 times, most recently from 2b53f79 to 10312f9 Compare July 26, 2024 08:17
@relativeci RelativeCI
Copy link

relativeci bot commented Jul 26, 2024 •
edited
Loading

#2163 Bundle Size — 10.77MiB (+0.02%).

9b61af4(current) vs cee0377 main#2162(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2163		      Baseline
#2162
Regression  Initial JS 1.88MiB(~+0.01%) 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 19.75% 17.42%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.84% 1.84%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2163		      Baseline
#2162
Regression  JS 8.96MiB (+0.02%) 8.96MiB
No change  CSS 892.47KiB 892.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:dirty-indicator Project dashboard

@jimtng
Add a dirty indicator on the title bar
056f30c 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the dirty-indicator branch from 10312f9 to 056f30c Compare July 26, 2024 08:33
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jul 28, 2024
@florian-h05
Add missing dirty indicator to chart and tabs edit page
9b61af4 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
florian-h05 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this nice addition!

FYI you forgot chart and tab edit, I have added the indicator there as well.

@florian-h05
Copy link
Contributor

I think this should be added to the docs, but I don't know where its best to put it.
@rkoshak Do you have an idea?

@florian-h05 florian-h05 added this to the 4.3 milestone Aug 4, 2024
@florian-h05 florian-h05 merged commit e5418b4 into openhab:main Aug 4, 2024
8 checks passed
@jimtng jimtng deleted the dirty-indicator branch August 4, 2024 11:50
@rkoshak
Copy link

rkoshak commented Aug 4, 2024

Does this only apply to rules or things, items, and transformations too?

If only rules I think the best place is under MainUI -> Settings -> Rules.

If all of these, a sentence probably needs to be added to each of these pages under MainUI -> Settings or a new section added to MainUI -> Settings to explain it.

@florian-h05
Copy link
Contributor

It applies to all of these.
I guess let’s then put it into Main UI -> Settings.

florian-h05 added a commit to florian-h05/openhab-docs that referenced this pull request Aug 6, 2024
@florian-h05
Main UI Setting: Document dirty indicator
71cb7b7 
Refs openhab/openhab-webui#2687.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Aug 6, 2024
Merged
@florian-h05
Copy link
Contributor

See openhab/openhab-docs#2345 for documentation.

stefan-hoehn pushed a commit to openhab/openhab-docs that referenced this pull request Aug 6, 2024
@florian-h05
Main UI Setting: Document dirty indicator (#2345)
ef07abc 
Refs openhab/openhab-webui#2687.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Sep 16, 2024
@florian-h05
Fix dirty indicator blocks subtitles
b4e5fb1 
Regression from openhab#2687.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Sep 16, 2024
Merged
florian-h05 added a commit that referenced this pull request Sep 16, 2024
@florian-h05
Fix dirty indicator blocks subtitles (#2758)
b7e2efe 
Regression from #2687.

The dirty indicator code blocked the use of subtitles, these were not
showing up anymore.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jimtng @florian-h05 @rkoshak