Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make webui work with non-root context path (#1290) #1291

Closed
wants to merge 5 commits into from

Conversation

altaroca
Copy link

@altaroca altaroca commented Jan 30, 2022

See explanation in in the issue #1290

things to consider:

  • testing for this will be difficult as it changes some logic at the heart of the ui.
  • testing needed for different browsers, uis, mobile apps. I have only used the main ui in chrome.
  • rest oauth will not work at non-root url. disable using console> bundle:stop org.openhab.core.io.rest.auth
  • this does not fix all absolute urls in the uis. Apache2 reverse proxy as in Introduce URL-path-prefix (hard-coded at least) openhab-core#150 can take care of many of those
  • in time it would probably be good to fix all urls

@altaroca altaroca requested review from ghys and a team as code owners January 30, 2022 15:48
@hubsif
Copy link
Contributor

hubsif commented Feb 5, 2022

Hi @altaroca,
FYI: I started looking into this and thank's to your work I really think this is doable (wouldn't have thought so a short while ago)! I refined and simplified a few things regarding the UI and will continue trying to solve open issues.

@ghys
Copy link
Member

ghys commented Feb 5, 2022

@altaroca - thanks for this effort!
I have yet to test this properly, give me a few days, but it's looking good already.
However please note the contributing rules regarding signing off of your commits: https://github.com/openhab/openhab-core/blob/main/CONTRIBUTING.md#sign-your-work
If you add the requested sign-off line as a comment in this discussion (Signed-off-by: ...) I will merge the PR with this line included.

@altaroca
Copy link
Author

altaroca commented Feb 5, 2022

Great! I am happy if you think this works. As for merging I leave it up to you @ghys if you want to merge it as is or wait for a more complete solution by @hubsif. In any case I sign over any copyright I may own on this PR to you. You don't have to mention me. Too much paperwork 😃

@florian-h05
Copy link
Contributor

Closing as this went stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants