-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a toggle method on Item #99
Merged
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bb7d578
Time: Add `updateTimeout` & `ZDTtoMillisFromNow`
florian-h05 0d56361
Time: Remove unnecessary checks from `updateTimeout`
florian-h05 4e0e2f0
Time: Monkey-patch ZonedDateTime `millisFromNow` & Add README section…
florian-h05 3a861df
Time: Remove `updateTimeout` & Document the returned Timer
florian-h05 d8cf009
Time: `millisFromNow` improvements
florian-h05 840f290
README: Improvements for JS-Joda and Timers
florian-h05 28acaeb
Implemented a toggle method on Item
rkoshak 94e8b95
Fixed docstring error breaking the build
rkoshak d1b3cd5
Merge pull request #93 from florian-h05/timer-improvements
digitaldan 28b3a21
Implemented a toggle method on Item
rkoshak 2bc83d7
Fixed docstring error breaking the build
rkoshak 0bcb93f
Addressing comments
rkoshak 25ec0fb
Merge branch 'toggle' of github.com:rkoshak/openhab-js into toggle
rkoshak 35f0108
Forgot to remove the old toggle method--
rkoshak 1f8a800
README.md Undoing erroneous merge
rkoshak a874def
Addressing comment to make cleaner
rkoshak 94a2f92
time.js: removing changes from erroneous merger
rkoshak c743259
Removing remenants of bad merge
rkoshak 97c7297
Removing remnants of bad merge
rkoshak e67d5a5
changed names of toggle methods
rkoshak 5b925b8
Addressing @florian-h05's comments.
rkoshak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be
sendToggleCommand
instead oftoggleCommand
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed