[time] Default to user-configured timezone & Reduce internal dependencies #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy on items and utils namespaces Fixes openhab#326. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Sep 16, 2024
Follow-up for openhab#383. Access to utils.javaInstantToJsInstant, utils.javaZDTToJsZDT and utils.javaZDTToJsZDTWithDefaultZoneSystem is kept for backward compatibility, but considered deprecated. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Sep 16, 2024
Follow-up for #383. Access to utils.javaInstantToJsInstant, utils.javaZDTToJsZDT and utils.javaZDTToJsZDTWithDefaultZoneSystem is kept for backward compatibility, but considered deprecated. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326 by reading the timezone configured in openHAB and making it the default for JS-Joda.
Also reduces the internal dependencies to other modules of the library, which always is a good thing for avoiding circular dependencies and other trouble.