Update bundling mechanism for globals injection caching #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This contains the required changes for the openhab-js injection caching inside the JS Scripting addon. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
digitaldan
approved these changes
Jan 2, 2023
|
Oh, thanks for that reminder. We also need a new release for this - I feel it is a bit to early to publish a 4.0 (due to some breaking changes it will be a new major). WDYT about a 3.2.1 release? |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Jan 2, 2023
* Update bundling mechanism for globals injection caching This contains the required changes for the openhab-js injection caching inside the JS Scripting addon. * Update DEPLOY.md * Do not exclude @openhab-globals.js from npm Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
I decided to create a 3.2.x branch out of the 3.2.0 tag and cherrypick this on top of it. |
Sounds good to me. |
florian-h05
added a commit
that referenced
this pull request
Jan 2, 2023
Fixes a regression from #218. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Jan 2, 2023
Fixes a regression from #218. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Jan 2, 2023
Fixes regression from openhab#218. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Jan 2, 2023
Fixes regression from #218. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the required changes for the openhab-js injection caching inside the JS Scripting addon in openhab/openhab-addons#14135.
Description