-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update timer docs #161
Update timer docs #161
Conversation
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@rkoshak |
It looks good to me. The only thing I would add is the generic case of just passing one local variable to the timer instead of |
That‘s possible, but …
I expect that it is not the same as with the function generator, I think you can mutate the var after the creation of the timer. I will modify the docs to have two ways of passing a var to a timer, both ways support |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@rkoshak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one addition to add a comment explaining what happens when you change myVariable to "Hello mutation!".
Once that comment is added I think this is good to go. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This improves the docs for
actions.ScriptExecution
Timers by explaining how to pass variables to the callback function.