[rules] Fix EventObject.itemName null is string instead of null
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue that I introduced in openhab#125. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
null is string instead of nullnull is string instead of null
|
@digitaldan Can you review? |
null is string instead of nullnull is string instead of null
digitaldan
approved these changes
Jun 9, 2022
|
👍 |
|
@digitaldan |
florian-h05
added a commit
to florian-h05/openhab-js
that referenced
this pull request
Jun 9, 2022
This allows `undefined` checks for the properties. Fixes the issue described in openhab#134. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
digitaldan
pushed a commit
that referenced
this pull request
Jun 14, 2022
* [rules] Refactor EventObject to only have properties which have a value This allows `undefined` checks for the properties. Fixes the issue described in #134. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [README] Update for EventObject changes Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Move ruleConfig JSDoc to extra typedef Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [README] Correct EventObject Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * Move CHANGELOG to extra file Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * Update CHANGELOG Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * Update rules/rules.js: Address review comment Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Co-authored-by: Jonathan Gilbert <github.10.jgilbert@xoxy.net> Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Extract logic for adding values from HashMap to function Addresses review comment. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Remove `command` from event object Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Event object holds no data when Core provided no event data Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Mark `state` var of Event object as deprecated Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Mark `receivedTrigger` of Event Object as deprecated Signed-off-by: Florian Hotze <florianh_dev@icloud.com> * [rules] Remove `status` from Event object JSDoc Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Co-authored-by: Jonathan Gilbert <github.10.jgilbert@xoxy.net>
null is string instead of nullnull is string instead of null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that I introduced in #125.
I added
toString()to event.itemName, but this made null checks fail because even null is now a string. I double checked, and itemName is also string if I removetoString().Signed-off-by: Florian Hotze florianh_dev@icloud.com