[time] Fix isBetweenTimes fails with time.toZDT not a function (#151

) * [time] Fix `isBetweenTimes` fails with `time.toZDT` not a function Fixes #150. Previous PR #137 changed the way how toZDT is defined, which broke isBetweenTimes. * Update CHANGELOG Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
openhab · Aug 17, 2022 · 5be991d · 5be991d
1 parent cec1cba
commit 5be991d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 | Type        | Namespace | Description                                                              | Reference                                      | Breaking |
 |-------------|-----------|--------------------------------------------------------------------------|------------------------------------------------|----------|
+| Bugfix      | `time`    | `isBetweenTimes` fails with: TypeError: `time.toZDT` is not a function   | https://github.com/openhab/openhab-js/pull/151 | No       |
 
 Also see the [Release Milestone](https://github.com/openhab/openhab-js/milestone/3).
 

diff --git a/time.js b/time.js
@@ -283,8 +283,8 @@ time.ZonedDateTime.prototype.toToday = function () {
  * @returns {boolean} true if this is between start and end
  */
 time.ZonedDateTime.prototype.isBetweenTimes = function (start, end) {
-  const startTime = time.toZDT(start).toLocalTime();
-  const endTime = time.toZDT(end).toLocalTime();
+  const startTime = toZDT(start).toLocalTime();
+  const endTime = toZDT(end).toLocalTime();
   const currTime = this.toLocalTime();
 
   // time range spans midnight