Fix QuantityType#eql? raising exception on incompatible QuantityType unit #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52a5423 to
12cac5c
Compare
508516f to
8b092be
Compare
|
I've restored eql? and added a unit compatibility check to avoid the exception from core's compare_to |
eda0315 to
7b25386
Compare
eae3c33 to
90ec40e
Compare
ccutrer
requested changes
Feb 17, 2025
spec/openhab/dsl_spec.rb
Outdated
| @@ -483,7 +483,7 @@ | |||
| expect(2 * w).to eql 10 | "W" | |||
| expect((2 * kw).to_i).to eq 10_000 | |||
| expect(2 * w == 10).to be true | |||
| expect(5 / w).to eql 1 | "W" | |||
| expect(5 / w).to eql 1 | "/W" | |||
| expect((2 * w / 2)).to eql w | |||
There was a problem hiding this comment.
You need to add a not_to eql case for when it's false
There was a problem hiding this comment.
I can't think of a good not_to eql check to add, so I added a check against kw. Do you have a better idea?
…unit Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
90ec40e to
a6c07fe
Compare
ccutrer
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in our spec which core was happily allowing:
(1 | "1/W").compare_to(1 | "W")used to return0.openHAB 5.0 now throws an exception when comparing invertible unit.
Relevant PR