Allow passing an array of channels to item builder #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
reviewed
Dec 29, 2024
Also add fluent aliases for adding multiple channels, groups and tags, and clarify documentation. Also fixes calling `channel` on a `GroupItemBuilder`, because it was being shadowed by `Terse#channel`, because `DSL` was getting included unecessarily (we only need `EntityLookup`, which is already explicitly included). Fixes openhab#374 Signed-off-by: Cody Cutrer <cody@cutrer.us>
a020e1b to
1da6fbf
Compare
jimtng
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add fluent aliases for adding multiple channels, groups and tags, and clarify documentation.
Also fixes calling
channelon aGroupItemBuilder, because it was being shadowed byTerse#channel, becauseDSLwas getting included unecessarily (we only needEntityLookup, which is already explicitly included).Fixes #374