-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for JSR223 cache preset #1937
Conversation
Signed-off-by: Jan N. Klug <github@klug.nrw>
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site settings. |
Does it make sense to include a Nashorn example? I think it'll be the same as Groovy/Jython.
I can see both ways since we really should encourage users to avoid Nashorn, but it's there now and we have the add-on on the marketplace to continue support when we move to Java 17. @jimtng, jRuby's import should be similar too, right? I personally would really like to see jRuby represented also. |
I can add it if someone confirms it's working. I don't have a JDK 11 installed, so can't test Nashorn. |
Actually, I wonder if it's a better test if it's tested with the Nashorn add-on on the marketplace. I need to update my OH before I can test it and I'm just about out of time for the day. If I don't see anything I can try the test tomorrow. |
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small remark.
From the discussion it would be best to wait until you have clarified the example?
Signed-off-by: Jan N. Klug <github@klug.nrw>
The Nashorn example is already there. We can wait for the ruby example. |
Maybe @ccutrer can provide it after finishing ccutrer/openhab-jrubyscripting#83 |
Yeah, don't wait in Ruby to get this merged. I'll make sure we get a Ruby example in in another PR. |
Do we also want to provide a JS Scripting (GraalJS) example? If yes, in which way? As this is one the JSR223 page, it would make sense to document the raw access without using the helper libray. If we want to document it using the helper library, this addition is something for a follow up PR, as I currently don't have the new cache implemented in the library. |
Co-authored-by: Wouter Born <github@maindrain.net>
@florian-h05 I don‘t think that is necessary since the helper libraries are always installed, correct? |
The helper libraries are always installed. I'm not sure what you refer to with
|
An example without the helper libraries. There is already an example for JS Scripting. I can add „GraalJS“ to the tab-title if you want. |
I've just checked it, looks fine 👍
Not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing left from my side and alle examplers are available.
Anything left to wait for from your side?
If not please give a short ping and i will merge.
IMO you can merge. |
Related to openhab/openhab-core#2887
Signed-off-by: Jan N. Klug github@klug.nrw