Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install add-on discovery file from openhab-addons #1604

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Install add-on discovery file from openhab-addons #1604

merged 4 commits into from
Dec 6, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Nov 8, 2023

J-N-K added 2 commits November 8, 2023 18:45
@J-N-K
Addon discovery
a4fd30a 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K
fix
decd3a5 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the awaiting other PR Depends on another PR label Nov 8, 2023
@J-N-K J-N-K requested a review from a team as a code owner November 8, 2023 20:10
@J-N-K
Copy link
Member Author

J-N-K commented Nov 8, 2023

@andrewfg The aggregated file is copied to <userdata>/addons. You should read all files from that folder, we can then easily add other XMLs (e.g. for zwave and zigbee).

@J-N-K
address review comments
25efb36 
Signed-off-by: Jan N. Klug <github@klug.nrw>
This was referenced Nov 9, 2023
Merged
Closed
Merged
@J-N-K
address review comment
bf272a6 
Signed-off-by: Jan N. Klug <github@klug.nrw>
andrewfg
andrewfg approved these changes Nov 9, 2023
View reviewed changes
distributions/openhab/pom.xml
@@ -170,6 +170,7 @@
<feature>system</feature>
<feature>openhab-runtime-base</feature>
<feature>openhab-runtime-ui</feature>
<feature>openhab-addon-discovery</feature>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mherwege
Copy link
Contributor

LGTM

kaikreuzer
kaikreuzer approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewfg andrewfg added rebuild Triggers a new PR build and removed rebuild Triggers a new PR build awaiting other PR Depends on another PR labels Dec 6, 2023
@andrewfg
Copy link
Contributor

andrewfg commented Dec 6, 2023

@J-N-K I think this PR should now build. Or??

@kaikreuzer
Copy link
Member

Yes, it does - I only waited with the merge until the build went green and then forgot about it. 🤦

@kaikreuzer kaikreuzer merged commit f98a08f into openhab:main Dec 6, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 6, 2023
@J-N-K J-N-K deleted the addon-xml branch December 6, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@andrewfg andrewfg andrewfg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@J-N-K @mherwege @andrewfg @kaikreuzer