Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid stack overflow - don't log a message within the log handler #4556

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Avoid stack overflow - don't log a message within the log handler #4556

merged 2 commits into from
Jan 14, 2025
+1 −2

Conversation

cdjackson
Copy link
Contributor

Logging a log message within the log handler causes a stack overflow.

@cdjackson
Avoid stack overflow - don't log a message within the log handler
6685251 
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@cdjackson cdjackson requested a review from a team as a code owner January 12, 2025 06:56
@cdjackson
Don't log error
9b859bf 
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
@holgerfriedrich holgerfriedrich requested a review from J-N-K January 12, 2025 08:54
@cdjackson
Copy link
Contributor Author

I think it would be good to get this merged if possible - this is a simple change so should be easy to review, but quite an annoying bug.

Thanks.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jan 14, 2025
@J-N-K J-N-K added this to the 5.0 milestone Jan 14, 2025
@J-N-K J-N-K merged commit 1b203d1 into openhab:main Jan 14, 2025
2 checks passed
@cdjackson cdjackson deleted the logger-exception branch January 14, 2025 08:08
@cdjackson
Copy link
Contributor Author

Thanks @J-N-K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cdjackson @J-N-K