Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start SPI Fly (OSGi service loader) early #4526

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Start SPI Fly (OSGi service loader) early #4526

merged 1 commit into from
Dec 28, 2024

Conversation

florian-h05
Copy link
Contributor

Related to #4466.

This was referenced Dec 28, 2024
Merged
Open
florian-h05
florian-h05 commented Dec 28, 2024
View reviewed changes
bom/runtime/pom.xml Outdated
@@ -775,6 +775,18 @@
<version>${jetty.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I am not sure whether we need those dependencies, but I would think so.

@J-N-K
Copy link
Member

J-N-K commented Dec 28, 2024

Please resolve the itests and convert to a PR.

@florian-h05
Start spifly early
d0fabb6 
Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05
Copy link
Contributor Author

florian-h05 commented Dec 28, 2024 •
edited
Loading

My distro build works fine without adding jetty-alpn-server and jetty-alpn-java-server compile dependencies.
Do we need them or not? I cannot really find any information only, but it seems we do not need them as JDK 21 provides ALPN APIs.

Also see https://github.com/jetty-project/jetty-alpn:

The ALPN APIs have been backported from Java 9 to OpenJDK 8u252. Therefore, since OpenJDK 8u252 there is no more need for the Jetty ALPN boot jar provided by this project.

@florian-h05 florian-h05 changed the title Preparations for enabling HTTP/2 for HTTPS Start SPI Fly (OSGi service loader) early Dec 28, 2024
@florian-h05 florian-h05 marked this pull request as ready for review December 28, 2024 17:08
@florian-h05 florian-h05 requested a review from a team as a code owner December 28, 2024 17:08
@holgerfriedrich holgerfriedrich mentioned this pull request Dec 28, 2024
Open
@J-N-K
Copy link
Member

J-N-K commented Dec 28, 2024

I don't think we need them as compile dependencies, it's enough that they are available at runtime.

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Dec 28, 2024
@J-N-K J-N-K added this to the 5.0 milestone Dec 28, 2024
@J-N-K J-N-K merged commit 7a61dc4 into openhab:main Dec 28, 2024
3 checks passed
@florian-h05 florian-h05 deleted the http2 branch December 28, 2024 17:35
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Dec 28, 2024
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
797156e 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Jan 1, 2025
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
1dd9aa4 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Jan 5, 2025
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
0261156 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Jan 6, 2025
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
e4519ed 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Jan 7, 2025
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
7946deb 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Jan 16, 2025
@holgerfriedrich
Revert "Start spifly early (openhab#4526)"
422d433 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @J-N-K