Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 17 build, switch to 21 #4483

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

holgerfriedrich
Copy link
Member

To be delayed until 4.3 is released.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich marked this pull request as ready for review December 15, 2024 19:01
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner December 15, 2024 19:01
@holgerfriedrich
Copy link
Member Author

I have reconfigured branch protection in core to require Java21 only (getting rid of two possibly failing builds).
Until this is merged, 3 build actions are still done.

Can someone pls. help me to change Jenkins core PR build to J21 as well? I don't know how to proceed with this.
@wborn @kaikreuzer ?

@holgerfriedrich holgerfriedrich removed the work in progress A PR that is not yet ready to be merged label Dec 15, 2024
@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Dec 15, 2024
@wborn
Copy link
Member

wborn commented Dec 15, 2024

Can someone pls. help me to change Jenkins core PR build to J21 as well?

I switched them all over to use JDK 21.

@holgerfriedrich
Copy link
Member Author

Thanks, @wborn. Now Action and Jenkins seem to run fine.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit c2d8392 into openhab:main Dec 15, 2024
3 checks passed
@kaikreuzer kaikreuzer added this to the 5.0 milestone Dec 15, 2024
@holgerfriedrich holgerfriedrich deleted the pr-java21 branch December 15, 2024 20:21
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this pull request Dec 15, 2024
Related to  openhab/openhab-core#4483

---------

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants