UpnpAddonFinder execute M-SEARCH ST: ssdp:all #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
|
@mherwege / @kaikreuzer I am inclined to think that we should merge this one anyway, since -- even if it does not resolve the deconz issue -- it does align the behaviour of UpnpAddonFinder and UpnpDiscoveryService. => WDYT? |
|
LGTM |
J-N-K
approved these changes
Dec 12, 2023
andrewfg
added a commit
to andrewfg/openhab-core
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes openhab/openhab-addons#16036
In the above-mentioned issue, it has been reported that the UPnpAddonFinder may not be finding computers which are running the deconz application. Whereas by contrast the deconz binding's bridge discovery (based on UpnpDiscoveryParticipant) does find the respective computer.
A potential reason could be that
UpnpAddonFinderissues a root device search (M-SEARCH ST: upnp:rootdevice) and perhaps the deconz application has a bug whereby it does not respond to root device searches.On the other hand the
UpnpDiscoveryServiceissues both a root device search plus also a 'catch-all' search (M-SEARCH ST: ssdp:all) so perhaps the deconz application does respond to the latter search but not the former.Notes:
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch