Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timer cancellation in automation cache #3204

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 8, 2022

The check for scheduling a cancellation task did not include the Timer class of the automation bundle.

@florian-h05 Can you check if this works for you?

Signed-off-by: Jan N. Klug github@klug.nrw

Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Dec 8, 2022
@J-N-K J-N-K requested a review from a team as a code owner December 8, 2022 18:52
@florian-h05
Copy link
Contributor

@J-N-K Thanks for the quick fix, it works!
FYI, seems like you have a spotless issue.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@wborn wborn merged commit 987cf22 into openhab:main Dec 8, 2022
@wborn wborn added this to the 3.4 milestone Dec 8, 2022
@J-N-K J-N-K deleted the bug-cachetimer branch December 8, 2022 20:46
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: 987cf22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants