Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an thing update fails, information about the cause is not provided #4557

Open
docbender opened this issue Jan 13, 2025 · 0 comments · May be fixed by #4558
Open

When an thing update fails, information about the cause is not provided #4557

docbender opened this issue Jan 13, 2025 · 0 comments · May be fixed by #4558
Labels
bug An unexpected problem or unintended behavior of the Core

Comments

@docbender
Copy link
Contributor

Expected Behavior

In BaseThingHandler updateThing method prints a log message with cause of update fail.

Current Behavior

Only information about blocked update is provided in the log message. Information about the result of validation is missing.

Possible Solution

Update log message in the catch block of updateThing method with the validation message:

logger.warn( "Attempt to update thing '{}' with a thing containing invalid configuration '{}' blocked. This is most likely a bug: {}", thing.getUID(), thing.getConfiguration(), e.getValidationMessages());

Steps to Reproduce (for Bugs)

Context

It is nice to have if you have problem with a binding.

Your Environment

  • Version used: openHAB 4.3.1
  • Environment name and version : Java21
  • Operating System and version (desktop or mobile, Windows 11, Raspbian Bullseye, ...): Debian 12
@docbender docbender added the bug An unexpected problem or unintended behavior of the Core label Jan 13, 2025
docbender added a commit to docbender/openhab-core that referenced this issue Jan 13, 2025
Fixes openhab#4557

Signed-off-by: Vita Tucek <vita.tucek@seznam.cz>
@docbender docbender linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant