-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gnu.io [3.12,6) version range in package imports #7589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer
approved these changes
May 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
gnlpfjh
pushed a commit
to gnlpfjh/openhab-addons
that referenced
this pull request
May 11, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
gnlpfjh
added a commit
to gnlpfjh/openhab-addons
that referenced
this pull request
May 11, 2020
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
gnlpfjh
added a commit
to gnlpfjh/openhab-addons
that referenced
this pull request
May 11, 2020
Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
cpmeister
pushed a commit
that referenced
this pull request
May 11, 2020
* Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in #7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
22 tasks
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
May 13, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
cpmeister
pushed a commit
that referenced
this pull request
May 13, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to #7589 Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: CSchlipp <christian@schlipp.de>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net> Signed-off-by: CSchlipp <christian@schlipp.de>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: CSchlipp <christian@schlipp.de>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
The first version of nrjavaserial with OSGi manifest entries is 3.12.0. The interface has not changed and is still the same with nrjavaserial 5.x. So defining a [3.12,6) version range allows for maximum flexibility. Related to: openhab/openhab-core#1464 Signed-off-by: Wouter Born <github@maindrain.net>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…b#6447) * Add support for dimmer * Improve receiving, recognition of serial messages * Null Annotations + gnu.io to core + Formatting * Improve sending of serial messages * Add bus connection to README * minor corrections * split method and use BolckingQueue in InternalBuffer * use diamond operator and format * Correct README * Remove gnu.io from pom.xml added in openhab#7589 Signed-off-by: Jonas Hohaus <jh@gnlpf.net>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
The gnu.io package is not only used in tests but is also a transitive dependency of net.wimpi:jamod Related to openhab#7589 Signed-off-by: Wouter Born <github@maindrain.net>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
It only has a reference to gnu.io in a JavaDoc so it shouldn't have been added in openhab#7589. Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first version of nrjavaserial with OSGi manifest entries is 3.12.0.
The interface has not changed and is still the same with nrjavaserial 5.x.
So defining a [3.12,6) version range allows for maximum flexibility.
Related to: openhab/openhab-core#1464
When the serial transport is used for these add-ons (#7573) we should remove these imports again. Though it can still take a while for all add-ons to be updated. Especially if we also need to add extra functionality to the transport which cannot be used on the 2.5.x branch.