Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Nullable annotations to core change #18231

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Adapt Nullable annotations to core change #18231

merged 1 commit into from
Feb 10, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich added the awaiting other PR Depends on another PR label Feb 5, 2025
@holgerfriedrich holgerfriedrich mentioned this pull request Feb 5, 2025
Merged
@holgerfriedrich
Adapt Nullable annotations to core change
ee0af66 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich removed the awaiting other PR Depends on another PR label Feb 9, 2025
@holgerfriedrich
Copy link
Member Author

I just merged the corresponding PR on core. This will be required after next core build.

lsiepel
lsiepel approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 6a1a41a into openhab:main Feb 10, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 10, 2025
@holgerfriedrich holgerfriedrich deleted the pr-nullable branch February 10, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@jlaur jlaur Awaiting requested review from jlaur jlaur is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerfriedrich @lsiepel