[mqtt] Set distinct action labels #18210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so they can be differentiated in MainUI Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
01087b4 to
a3d72ba
Compare
ccutrer
reviewed
Feb 1, 2025
| @@ -98,6 +98,8 @@ actionInputRetainLabel = Retain | |||
| actionInputRetainDesc = Retain message | |||
| actionLabel = publish an MQTT message | |||
| actionDesc = Publishes a value to the given MQTT topic. | |||
| actionRetainLabel = publish an MQTT message with retain option | |||
There was a problem hiding this comment.
I'd say "with given retain option".
Otherwise it sounds like this will always send retain: true
There was a problem hiding this comment.
Thanks for the correction
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
This is so they can be differentiated in MainUI Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so they can be differentiated in MainUI
Before
After
