Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mercedesme] bugfix auth problem causing http 412 error #18208

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Jan 31, 2025

Bugfix for auth problem observed yesterday in my system and also observed by community. Mercedes abandoned "too old" clients to access the data so version numbers needs to be adapted.

This is a showstopper because since yesterday old bindings are not working anymore. I recommend to put this PR into the next minor update to fix this as early as possible.

In addition small bugfix of subsequent JSON error which was reported by community

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 8e8bb06 into openhab:main Feb 2, 2025
2 checks passed
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Feb 2, 2025
@lolodomo lolodomo added this to the 5.0 milestone Feb 2, 2025
@lolodomo
Copy link
Contributor

lolodomo commented Feb 2, 2025

@weymann : you think we should backport that fix to 4.3.x?

@weymann
Copy link
Contributor Author

weymann commented Feb 2, 2025

@lolodomo

Yes, you can cherry pick these 3 commits and put them on top of 4.3.x branch.
I already tested it and confimred by community it's working

lolodomo pushed a commit that referenced this pull request Feb 8, 2025
* version update
* add catching JSONException

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
@lolodomo
Copy link
Contributor

lolodomo commented Feb 8, 2025

Change i snow backported to branch 4.3.x.

@lolodomo lolodomo added the patch A PR that has been cherry-picked to a patch release branch label Feb 8, 2025
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
* version update
* add catching JSONException

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants