Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro] Update real-time Moon Phase Age #18203

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 30, 2025

Instead of returning a constant value of the moon phase age relative to the start of the day, return the real-time calculation of the moon phase age on each channel update

See https://community.openhab.org/t/astro-binding-is-moon-phase-age-and-other-phase-channels-not-recalculated-with-the-thing-set-interval/162111

Instead of returning a constant value of the moon phase age relative to the start of the day,
return the real-time calculation of the moon phase age on each channel update

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/astro-binding-is-moon-phase-age-and-other-phase-channels-not-recalculated-with-the-thing-set-interval/162111/11

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 2, 2025
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit e7d44c9 into openhab:main Feb 2, 2025
2 checks passed
@lolodomo lolodomo added this to the 5.0 milestone Feb 2, 2025
@jimtng jimtng deleted the astro-moonphase-age branch February 2, 2025 13:45
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
Instead of returning a constant value of the moon phase age relative to the start of the day,
return the real-time calculation of the moon phase age on each channel update

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants