[radoneye] Add decay channel for HW v2 and simplify the code

[joerg1985]

This PR does fix the randoneye integration and simplifies the code by using the ConnectedBluetoothHandler.
For V2 devices a new channel decay is available showing the number of decays in the last timeframe.

Signed-off-by: Jörg Sautter joerg.sautter@gmx.net

[lsiepel]

Thanks. Changes look good, it just needs some more:

1. Thing upgrade instructiosn for the chagned and added channel
2. Properties file need to be updated (mvn i18n:generate-default-translations)
3. Optional: would be nice if you use this opportunity to fix some of the compiler null warnigs.

[joerg1985]

@lsiepel thanks for the input, i have updated the PR.
Regarding the changes in the orginal channel, the original BECQUEREL_PER_CUBIC_METRE and Units.BECQUEREL_PER_CUBIC_METRE are identical, so there is no change.
The other channel has been added to the instructions.xml, could you please double check the id in the file.
I did read the instructions to the XML format at https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types but im still unsure.

[jlaur]

I've had a look mostly at the update instructions, and have added a few comments.

The other channel has been added to the instructions.xml, could you please double check the id in the file.
I did read the instructions to the XML format at https://www.openhab.org/docs/developer/bindings/thing-xml.html#updating-thing-types but im still unsure.

It's important to test the update instructions as otherwise they can do more harm than good. You could create a managed Thing with the binding version before this PR (e.g. from the distribution), then install this version and verify that the new channel is added to your Thing automatically, and that the existing channel is updated with the correct dimension.

[jlaur]

For reference regarding the dimension fix: openhab/openhab-core#3608

[joerg1985]

I have updated the PR and tested the update, before:

And after:

[jlaur]

Thanks, LGTM! Since all @lsiepel's remarks have been addressed (and I didn't find anything either), we can merge while he is ⛷️'ing. 🙂