Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[huesync] - Fix for issue #18062 - Configuration (API Token) lost if device goes offline #18100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[huesync] - Fix for issue #18062 - Configuration (API Token) lost if device goes offline #18100

wants to merge 1 commit into from

Conversation

pgfeller
Copy link
Contributor

@pgfeller pgfeller commented Jan 12, 2025 •
edited
Loading

➡️ Refactoring of connection handling

  • Analyze and reproduce issue
    • setup 4.3.x branch for development (for bug fixing I prefer the stable branch)
  • Avoid exceptions in the constructor of the thing handler
  • Never delete configuration automatically
  • 🛠️ Improve exception handling work in progress
    • - Re-initialise connection (e.g. if IP/Hostname changed)
    • ...
  • interactive test of functionalities in productive environment
  • prepare for review

@pgfeller pgfeller added the work in progress A PR that is not yet ready to be merged label Jan 12, 2025
@pgfeller pgfeller self-assigned this Jan 12, 2025
@pgfeller pgfeller force-pushed the huesync/issue/18062 branch from f1dfb75 to 48daebe Compare January 12, 2025 21:55
@pgfeller pgfeller requested a review from lsiepel January 12, 2025 21:58
@pgfeller
Copy link
Contributor Author

Hi @lsiepel - I've added you as reviewer already, but the fix is far from ready to be merged. But maybe it is easier for you to follow how the fix evolves rather than to review all at once. That way you can also comment at any time if you have concerns.

hope you are fine and as always - thanks for your work for the community and especially for your support to me 🙂

@pgfeller pgfeller force-pushed the huesync/issue/18062 branch 2 times, most recently from c4c5cf6 to 552b178 Compare January 24, 2025 15:57
@pgfeller pgfeller added the bug An unexpected problem or unintended behavior of an add-on label Jan 24, 2025
@pgfeller pgfeller linked an issue Jan 24, 2025 that may be closed by this pull request
[huesync] Configuration (API Token) lost if device goes offline #18062
Open
@pgfeller pgfeller changed the title [WIP] fix(18062): 🛠️ [huesync] Configuration (API Token) lost if device goes offline [huesync] - Fix for issue #18062 - Configuration (API Token) lost if device goes offline Jan 24, 2025
@pgfeller pgfeller closed this Jan 24, 2025
@pgfeller pgfeller deleted the huesync/issue/18062 branch January 24, 2025 21:47
@pgfeller pgfeller restored the huesync/issue/18062 branch January 24, 2025 22:03
@pgfeller pgfeller reopened this Jan 24, 2025
@pgfeller pgfeller force-pushed the huesync/issue/18062 branch from 8c7960d to bd7e07a Compare January 24, 2025 22:39
@pgfeller
fix(18062): 🛠️ work in progress ...
116e8ce 
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
@pgfeller pgfeller force-pushed the huesync/issue/18062 branch from bd7e07a to 116e8ce Compare January 24, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel Awaiting requested review from lsiepel

At least 1 approving review is required to merge this pull request.

Assignees

@pgfeller pgfeller

Labels
bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[huesync] Configuration (API Token) lost if device goes offline
1 participant
@pgfeller