Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ahawastecollection] Fix IllegalArgumentException for Christmas Tree collection #17950

Merged
merged 1 commit into from
Jan 4, 2025
Merged

[ahawastecollection] Fix IllegalArgumentException for Christmas Tree collection #17950

merged 1 commit into from
Jan 4, 2025

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Dec 22, 2024 •
edited
Loading

Fixes: #17879

Test jar: https://1drv.ms/u/s!AnMcxmvEeupwj49KMnQ3vzEIZLkpRA?e=pmrC4d (should be 4.3.0 compatible)

Can be backported

@lsiepel
Add Christmas Tree
71effd6 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Dec 22, 2024
@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 4, 2025
@lsiepel lsiepel requested a review from a team January 4, 2025 15:15
@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 4, 2025

Fix confirmed by issue reporter.

@lsiepel lsiepel marked this pull request as ready for review January 4, 2025 15:15
@lsiepel lsiepel requested a review from soenkekueper as a code owner January 4, 2025 15:15
jlaur
jlaur approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 7cc9903 into openhab:main Jan 4, 2025
3 checks passed
@jlaur jlaur added this to the 5.0 milestone Jan 4, 2025
@jlaur
Copy link
Contributor

jlaur commented Jan 4, 2025

@lsiepel - I understand this fixes IllegalArgumentException and at the same time adds support for Christmas tree collection. The bug fix justifies a backport, but please consider the PR title as it sounds like a new feature and not like the binding is broken because of the damn Christmas tree. 😄

jlaur pushed a commit that referenced this pull request Jan 4, 2025
@lsiepel @jlaur
Add Christmas Tree (#17950)
4f24ebd 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Jan 4, 2025
@lsiepel lsiepel deleted the waste-bug-fix branch January 4, 2025 18:26
@lsiepel lsiepel changed the title [ahawastecollection] Add support for Christmas Tree collection [ahawastecollection] Fix IllegalArgumentException for Christmas Tree collection Jan 4, 2025
@lsiepel lsiepel mentioned this pull request Jan 9, 2025
Closed
@FlorianB79
Copy link

Is it possible to implement the fix in 4.3.1 for me as a user?

@lsiepel
Copy link
Contributor Author

lsiepel commented Jan 9, 2025 •
edited
Loading

Is it possible to implement the fix in 4.3.1 for me as a user?

You can use the above linked jar. (uninstall the bundled binding and drop this jar in your addon folder) or wait a few days as 4.3.2 is very close.

GearrelW pushed a commit to GearrelW/openhab-addons that referenced this pull request Jan 12, 2025
@lsiepel @GearrelW
Add Christmas Tree (openhab#17950)
11e9db9 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[ahawastecollection] IllegalArgumentException: Unknown waste type: Weihnachtsbäume
3 participants
@lsiepel @jlaur @FlorianB79