-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Implement Device Tracker #17831
[mqtt.homeassistant] Implement Device Tracker #17831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the very quick response!
...tant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/ComponentChannelType.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/DeviceTracker.java
Outdated
Show resolved
Hide resolved
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
While trying to merge this i noticed the commits have no signoff message. Could you try to fix this? Either rewrite a commit message or perform a new arbitrary commit with a proper signoff. |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
…rg/openhab/binding/mqtt/homeassistant/internal/component/DeviceTracker.java Signed-off-by: lsiepel <leosiepel@gmail.com>
…rg/openhab/binding/mqtt/homeassistant/internal/ComponentChannelType.java Signed-off-by: lsiepel <leosiepel@gmail.com>
b9e41f7
to
9b907ef
Compare
Yup, sorry, sometimes I forget :). I amended my initial commit (and left your two additional commits on top). |
I used to forget too, but since this can be automated by some setting in the ide (vscode) it never happens to me anymore. But you probably know that :-) |
* [mqtt.homeassistant] implement Device Tracker Signed-off-by: Cody Cutrer <cody@cutrer.us>
* [mqtt.homeassistant] implement Device Tracker Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
No description provided.