Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] Implement Device Tracker #17831

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 2, 2024

No description provided.

@ccutrer ccutrer requested a review from antroids as a code owner December 2, 2024 20:53
@ccutrer ccutrer changed the title [mqtt.homeassistant] implement Device Tracker [mqtt.homeassistant] Implement Device Tracker Dec 2, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the very quick response!

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/problem-with-device-tracker-and-binary-sensor-ha-convention-mqtt-discovery-for-local-apple-watch-iphone-and-ipad-discovery/153268/8

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 2, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Dec 2, 2024

While trying to merge this i noticed the commits have no signoff message. Could you try to fix this? Either rewrite a commit message or perform a new arbitrary commit with a proper signoff.

ccutrer and others added 3 commits December 2, 2024 14:31
Signed-off-by: Cody Cutrer <cody@cutrer.us>
…rg/openhab/binding/mqtt/homeassistant/internal/component/DeviceTracker.java

Signed-off-by: lsiepel <leosiepel@gmail.com>
…rg/openhab/binding/mqtt/homeassistant/internal/ComponentChannelType.java

Signed-off-by: lsiepel <leosiepel@gmail.com>
@ccutrer ccutrer force-pushed the mqtt-homeassistant-device_tracker branch from b9e41f7 to 9b907ef Compare December 2, 2024 21:31
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 2, 2024

Yup, sorry, sometimes I forget :). I amended my initial commit (and left your two additional commits on top).

@lsiepel
Copy link
Contributor

lsiepel commented Dec 3, 2024

Yup, sorry, sometimes I forget :). I amended my initial commit (and left your two additional commits on top).

I used to forget too, but since this can be automated by some setting in the ide (vscode) it never happens to me anymore. But you probably know that :-)

@lsiepel lsiepel merged commit 3f392ab into openhab:main Dec 3, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Dec 3, 2024
@ccutrer ccutrer deleted the mqtt-homeassistant-device_tracker branch December 3, 2024 05:11
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* [mqtt.homeassistant] implement Device Tracker

Signed-off-by: Cody Cutrer <cody@cutrer.us>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [mqtt.homeassistant] implement Device Tracker

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants