Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set openHAB system properties during tests #17592

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Oct 20, 2024

This will make sure tests write data to './target/openhab/userdata' instead of './userdata' etc. Prevents new files from appearing whenever running the Mi IO Binding tests.

This will make sure tests write data to './target/openhab/userdata' instead of './userdata' etc.
Prevents new files from appearing whenever running the Mi IO Binding tests.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team as a code owner October 20, 2024 10:52
@wborn wborn requested a review from marcelrv October 20, 2024 10:53
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the set-oh-test-system-properties branch from e0ca451 to fe17887 Compare October 20, 2024 13:44
@lsiepel lsiepel merged commit 2bdce1c into openhab:main Oct 20, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 20, 2024
@lsiepel lsiepel added the test label Oct 20, 2024
@wborn wborn deleted the set-oh-test-system-properties branch October 20, 2024 17:50
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
* Set openHAB system properties during tests

This will make sure tests write data to './target/openhab/userdata' instead of './userdata' etc.
Prevents new files from appearing whenever running the Mi IO Binding tests.

Signed-off-by: Wouter Born <github@maindrain.net>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
* Set openHAB system properties during tests

This will make sure tests write data to './target/openhab/userdata' instead of './userdata' etc.
Prevents new files from appearing whenever running the Mi IO Binding tests.

Signed-off-by: Wouter Born <github@maindrain.net>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* Set openHAB system properties during tests

This will make sure tests write data to './target/openhab/userdata' instead of './userdata' etc.
Prevents new files from appearing whenever running the Mi IO Binding tests.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants