Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linktap] Fix build #17493

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[linktap] Fix build #17493

merged 1 commit into from
Oct 1, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 1, 2024

@jlaur
Fix build
208172c 
Regression of openhab/openhab-core#4389

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on critical regression Regression that happened during the development of a release. Not shown on final release notes. labels Oct 1, 2024
@jlaur jlaur requested a review from a team as a code owner October 1, 2024 20:51
@jlaur jlaur mentioned this pull request Oct 1, 2024
Merged
@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 1, 2024
lsiepel
lsiepel approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. LGTM
Not sure why it is critical, as this is not released into any stable or milestone.

@lsiepel lsiepel merged commit 4651f5c into openhab:main Oct 1, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 1, 2024
@jlaur jlaur deleted the linktap-fix-build branch October 1, 2024 21:02
@jlaur jlaur removed the critical label Oct 1, 2024
@jlaur
Copy link
Contributor Author

jlaur commented Oct 1, 2024

Not sure why it is critical

Okay, maybe exageration, but since build is broken, snapshots are not being created.

@jlaur
Copy link
Contributor Author

jlaur commented Oct 1, 2024

To be fair, actually regression of #17235. The core PR was merged first, so when #17235 was merged shortly after, it was already broken, but this was not detected because the latest build succeeded.

@dag81
Copy link
Contributor

dag81 commented Oct 4, 2024

@jlaur @lsiepel Thank you for looking and sorting - sorry this weeks been manic at work and just catching up now. I couldn't figure out how that got through the pipelines until I saw the comments above. For my future reference where are the outputs from these pipelines for the regression runs?

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jlaur @joni1993
Fix build (openhab#17493)
53a9727 
Regression of openhab/openhab-core#4389

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@jlaur @matchews
Fix build (openhab#17493)
a85b852 
Regression of openhab/openhab-core#4389

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@jlaur
Fix build (openhab#17493)
d80453d 
Regression of openhab/openhab-core#4389

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jlaur @dag81 @lsiepel