[kaleidescape] Add movie end time and music title channels #17423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
requested changes
Sep 16, 2024
Comment on lines
388
to
390
| <tags> | ||
| <tag>Timestamp</tag> | ||
| </tags> |
There was a problem hiding this comment.
You can't set only a property, you have to combine it with a Point property.
There was a problem hiding this comment.
Thanks. There are many examples of this without Point in the shelly binding.
There was a problem hiding this comment.
It was not defined as expected in the Shelly binding !
Rather use a more specific value. I hesitate between "Status" and "Measurement".
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Sep 24, 2024
…7423) * Add movie end time and music end title channels Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…7423) * Add movie end time and music end title channels Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…7423) * Add movie end time and music end title channels Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…7423) * Add movie end time and music end title channels Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following channels to the binding: