-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maven-javadoc-plugin upgrade #16715
Conversation
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlaur sorry for the typo in my PR and thanks for fixing this
No worries, luckily it was easy to spot and quick to fix. 😉 |
Next time I should start writing a script for doing the updates (which can exclude things that are done together with Karaf upgrades, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't have experience with that, but it sure sounds like an interesting idea that could make upgrades easier and safer. |
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
#16683 mentioned:
but actually changed version to 3.12.0, causing this build warning:
I verified with openhab/openhab-core#4197 that 3.6.3 is correct:
https://github.com/openhab/openhab-core/blob/4dfbfb4995820089fbb92aaa64db09437d7e55ac/pom.xml#L324-L326