Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven-javadoc-plugin upgrade #16715

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 4, 2024

#16683 mentioned:

maven-javadoc-plugin, 3.2.0 to 3.6.3, see https://github.com/apache/maven-javadoc-plugin/releases

but actually changed version to 3.12.0, causing this build warning:

[WARNING] The POM for org.apache.maven.plugins:maven-javadoc-plugin:jar:3.12.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.apache.maven.plugins:maven-javadoc-plugin:3.12.0: Plugin org.apache.maven.plugins:maven-javadoc-plugin:3.12.0 or one of its dependencies could not be resolved: org.apache.maven.plugins:maven-javadoc-plugin:jar:3.12.0 was not found in https://openhab.jfrog.io/openhab/libs-snapshot during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of openhab-snapshot has elapsed or updates are forced

I verified with openhab/openhab-core#4197 that 3.6.3 is correct:
https://github.com/openhab/openhab-core/blob/4dfbfb4995820089fbb92aaa64db09437d7e55ac/pom.xml#L324-L326

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from holgerfriedrich May 4, 2024 13:38
@jlaur jlaur requested a review from a team as a code owner May 4, 2024 13:38
@jlaur jlaur added the infrastructure Build system and Karaf related issues and PRs label May 4, 2024
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlaur sorry for the typo in my PR and thanks for fixing this

@holgerfriedrich holgerfriedrich added the regression Regression that happened during the development of a release. Not shown on final release notes. label May 4, 2024
@jlaur
Copy link
Contributor Author

jlaur commented May 4, 2024

sorry for the typo in my PR and thanks for fixing this

No worries, luckily it was easy to spot and quick to fix. 😉

@holgerfriedrich
Copy link
Member

Next time I should start writing a script for doing the updates (which can exclude things that are done together with Karaf upgrades, etc.)
Maybe we should use something like the service "renovate" to do this in a semi-automatic way like dependabot does.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit cc439e2 into openhab:main May 5, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 5, 2024
@jlaur
Copy link
Contributor Author

jlaur commented May 5, 2024

Maybe we should use something like the service "renovate" to do this in a semi-automatic way like dependabot does.

I don't have experience with that, but it sure sounds like an interesting idea that could make upgrades easier and safer.

@jlaur jlaur deleted the maven-javadoc-plugin branch May 11, 2024 11:51
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants