-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Correction of Last-Event group #16684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
reviewed
Apr 28, 2024
...main/java/org/openhab/binding/netatmo/internal/handler/channelhelper/EventChannelHelper.java
Outdated
Show resolved
Hide resolved
Conflict has to be resolved after the merge of another PR. |
lolodomo
requested changes
Apr 29, 2024
...main/java/org/openhab/binding/netatmo/internal/handler/channelhelper/EventChannelHelper.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/netatmo/internal/handler/channelhelper/EventChannelHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Code review n°1 Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org>
76049ed
to
b3c01a3
Compare
lolodomo
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Correction of Last-Event group Signed-off-by: root <gael@lhopital.org> Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete resolution of issue #15883 .
Enhanced: