Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Correction of Last-Event group #16684

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Apr 26, 2024

Complete resolution of issue #15883 .

Enhanced:

  • vpnUrl that should never be null.

@clinique clinique requested a review from lolodomo as a code owner April 26, 2024 14:42
@jlaur jlaur linked an issue Apr 26, 2024 that may be closed by this pull request
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Apr 28, 2024
@lolodomo
Copy link
Contributor

Conflict has to be resolved after the merge of another PR.

@clinique clinique requested a review from lolodomo April 28, 2024 23:09
Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Code review n°1

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 57025ce into openhab:main Apr 29, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 29, 2024
@clinique clinique deleted the netatmo_15883_3 branch April 29, 2024 11:46
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* Correction of Last-Event group

Signed-off-by: root <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Netatmo] Only few channels are working for Presence Camera
3 participants