Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SAT plugin to 0.16.0 #16582

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Upgrade SAT plugin to 0.16.0 #16582

merged 1 commit into from
Mar 31, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Mar 26, 2024

Static code analysis: SAT plugin 0.16.0 has been released yesterday.
https://github.com/openhab/static-code-analysis/releases/tag/0.16.0

This PR upgrades to this version and modifies code which leads to build error with new version of SpotBugs.

Refs: openhab/openhab-distro#1590

Copy link
Contributor

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for MQTT

Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add null checks to prevent NPE.

Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Copy link
Member Author

Sorry for force-pushing, but it was necessary to resolve merge conflict with current main branch.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade. 👍

@wborn wborn merged commit df884ac into openhab:main Mar 31, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Mar 31, 2024
@holgerfriedrich holgerfriedrich deleted the pr-sat0160 branch March 31, 2024 09:03
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Modify code which leads to build error with new version of SpotBugs.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants