-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwebnet] Replace gnu.io dependency with serial transport #16376
Merged
wborn
merged 7 commits into
openhab:main
from
mvalla:openwebnet-replace-gnu.io-dependency
Feb 5, 2024
Merged
[openwebnet] Replace gnu.io dependency with serial transport #16376
wborn
merged 7 commits into
openhab:main
from
mvalla:openwebnet-replace-gnu.io-dependency
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instead of returning @nullable Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
handling. Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
…Use own4j 0.12.0 Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
This was referenced Feb 5, 2024
wborn
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! 👍 It's nice to see that it only adds a very thin abstraction layer to be able to use different serial implementations with openwebnet4j. 🙂
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…#16376) Signed-off-by: Massimo Valla <mvcode00@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…#16376) Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a new version of openwebnet4j lib (0.12.0) to avoid dependency of the binding on
gnu.io
.Implementation
Version 0.12.0 of the openwebnet4j lib defines a new
SerialPortProvider
interface to discover and interact with serial ports.With this PR the binding now provides a
SerialPortProviderAdapter
implementation of openwebnet4j'sSerialPortProvider
based on OH Serial Transport to provide serial port access to the lib, thus making the binding independent fromgnu.io
.It has been tested extensively in a real environment with the Zigbee serial-USB dongle integrated by the binding.
Related to #7573