Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boschshc] Add support for Universal Switch I + II #16274

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[boschshc] Add support for Universal Switch I + II #16274

merged 2 commits into from
Jan 18, 2024
+542 −9

Conversation

david-pace
Copy link
Member

  • add thing type and channel type definitions
  • re-generate i18n file
  • add constants
  • add model classes and enums
  • implement service and handlers
  • register handlers in factory
  • register devices in discovery

closes #16244

@david-pace david-pace added the enhancement An enhancement or new feature for an existing add-on label Jan 13, 2024
@david-pace david-pace requested a review from jlaur January 13, 2024 20:34
@david-pace david-pace force-pushed the 16244-universal-switch-2 branch from eb4d9bd to 1667f5d Compare January 13, 2024 20:42
@david-pace
[boschshc] Support for Universal Switch I + II
edb8d2d 
- add thing type and channel type definitions
- re-generate i18n file
- add constants
- add model classes and enums
- implement service and handlers
- register handlers in factory
- register devices in discovery

closes openhab#16244

Signed-off-by: David Pace <dev@davidpace.de>
@david-pace david-pace force-pushed the 16244-universal-switch-2 branch from 1667f5d to edb8d2d Compare January 13, 2024 20:48
@david-pace david-pace added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 13, 2024
GerdZanker
GerdZanker approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@GerdZanker GerdZanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no Universal Switches and therefore only did a review of the files.
You changes are as usual: consistent, clean with comments and unit tests - very good work.
Thank you @david-pace

lsiepel
lsiepel reviewed Jan 14, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question and minor comment.

@david-pace
add state options, use TimeZoneProvider
c2b1683 
Signed-off-by: David Pace <dev@davidpace.de>
lsiepel
lsiepel approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let me know when testing is finished and i'll merge the PR.

@david-pace
Copy link
Member Author

Hi @lsiepel, I tested the code well with Universal Switch II. It would be good if someone could test with Universal Switch I as well. But of the testers I know, no one has a first generation device.

On the other hand, Universal Switch I has the very same service API, just the button names are different and I used the ones specified in the official Bosch API and also confirmed with a Python implementation (line 625). So I'm fairly confident that this will work, too.

If you agree that the two sources are enough, we can merge this PR 🚀

@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jan 18, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jan 18, 2024

Hi @lsiepel, I tested the code well with Universal Switch II. It would be good if someone could test with Universal Switch I as well. But of the testers I know, no one has a first generation device.

On the other hand, Universal Switch I has the very same service API, just the button names are different and I used the ones specified in the official Bosch API and also confirmed with a Python implementation (line 625). So I'm fairly confident that this will work, too.

If you agree that the two sources are enough, we can merge this PR 🚀

As it is a new supported device, there is no risc of regression and we have some milestones before the next stable, hopefully it will get some mileage.

@lsiepel lsiepel merged commit 15642af into openhab:main Jan 18, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jan 18, 2024
@david-pace david-pace deleted the 16244-universal-switch-2 branch January 18, 2024 21:44
@jlaur jlaur changed the title [boschshc] Support for Universal Switch I + II [boschshc] Add support for Universal Switch I + II Jan 18, 2024
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@david-pace @andrasU
[boschshc] Support for Universal Switch I + II (openhab#16274)
54770c6 
* [boschshc] Support for Universal Switch I + II

- add thing type and channel type definitions
- re-generate i18n file
- add constants
- add model classes and enums
- implement service and handlers
- register handlers in factory
- register devices in discovery

closes openhab#16244

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
@david-pace david-pace mentioned this pull request Jan 31, 2024
Merged
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@david-pace @austvik
[boschshc] Support for Universal Switch I + II (openhab#16274)
5d85497 
* [boschshc] Support for Universal Switch I + II

- add thing type and channel type definitions
- re-generate i18n file
- add constants
- add model classes and enums
- implement service and handlers
- register handlers in factory
- register devices in discovery

closes openhab#16244

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@david-pace @joni1993
[boschshc] Support for Universal Switch I + II (openhab#16274)
12ef727 
* [boschshc] Support for Universal Switch I + II

- add thing type and channel type definitions
- re-generate i18n file
- add constants
- add model classes and enums
- implement service and handlers
- register handlers in factory
- register devices in discovery

closes openhab#16244

Signed-off-by: David Pace <dev@davidpace.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GerdZanker GerdZanker GerdZanker approved these changes

@lsiepel lsiepel lsiepel approved these changes

@jlaur jlaur Awaiting requested review from jlaur

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[boschshc] Support for Universal Switch II
3 participants
@david-pace @lsiepel @GerdZanker