Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] Change the conversion of the DPT251.600 to use RGB and White. #15773

Closed
wants to merge 1 commit into from

Conversation

genesis81
Copy link
Contributor

With the new feature, the HSBType is converted into RGBW, and we convert the status signal from the KNX back into an HSB value.

Due to the conversion, some accuracy is lost, but the result is approximately correct.

Need #openhab/openhab-core#3849 to work.

@genesis81 genesis81 changed the title Change the conversion of the DPT251.600 to use RGB and White. [knx] Change the conversion of the DPT251.600 to use RGB and White. Oct 17, 2023
@lolodomo lolodomo added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Oct 18, 2023
@genesis81 genesis81 closed this Nov 12, 2023
the status signal from the KNX back into an HSB value.

Due to the conversion, some accuracy is lost, but the result is
approximately correct.

Signed-off-by: Marco Müller <marco@ms-mueller.ch>
@genesis81 genesis81 reopened this Nov 12, 2023
@holgerfriedrich
Copy link
Member

Rebuilds can be triggered by adding and removing the label "rebuild".
Btw: We have to wait until the nightly build of core creates another snapshot.

@J-N-K
Copy link
Member

J-N-K commented Nov 12, 2023

I have triggered a core build. It should be available in about an hour.

@genesis81
Copy link
Contributor Author

genesis81 commented Nov 12, 2023

Rebuilds can be triggered by adding and removing the label "rebuild". Btw: We have to wait until the nightly build of core creates another snapshot.

Thanks for the information, but my mistake was that i pull the actual branch and push. I didn't see that i lost my changes. Normaly i work with .NET and Visual Studio. NetBeans is not my prefered IDE.

@genesis81
Copy link
Contributor Author

Rebuilds can be triggered by adding and removing the label "rebuild".

I can't apply new labels to the Pull Request. No rights.

@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 13, 2023
@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Nov 18, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

Let's wait still few days for a potential feedback from @kaikreuzer or @holgerfriedrich

@holgerfriedrich
Copy link
Member

Pls do not merge yet.

@holgerfriedrich
Copy link
Member

This PR would actually change the behavior of the binding. As of now you can use HSBType for RGB and a PercentType for the W channel.

I think it is useful to bring in the conversion from RGBW which merges RGB and W into HSBType - but users should be able to select both the old and the proposed handling. I am thinking of using a custom DPT like 251.60600.

I already have a draft for this, give me some time to check.

@lolodomo lolodomo added the won't fix Invalid Issues and requests that do not fit the specified add-on label Dec 10, 2023
@lolodomo
Copy link
Contributor

Pls do not merge yet.

I added the tag "won't fix", even if not really appropriate, to avoid a merge.
Should we simply close this PR @holgerfriedrich ?

@lolodomo lolodomo added invalid and removed won't fix Invalid Issues and requests that do not fit the specified add-on labels Dec 10, 2023
@genesis81 genesis81 closed this Jan 28, 2024
@genesis81
Copy link
Contributor Author

Done with #16078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants