-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[knx] Change the conversion of the DPT251.600 to use RGB and White. #15773
Conversation
the status signal from the KNX back into an HSB value. Due to the conversion, some accuracy is lost, but the result is approximately correct. Signed-off-by: Marco Müller <marco@ms-mueller.ch>
Rebuilds can be triggered by adding and removing the label "rebuild". |
I have triggered a core build. It should be available in about an hour. |
Thanks for the information, but my mistake was that i pull the actual branch and push. I didn't see that i lost my changes. Normaly i work with .NET and Visual Studio. NetBeans is not my prefered IDE. |
I can't apply new labels to the Pull Request. No rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Let's wait still few days for a potential feedback from @kaikreuzer or @holgerfriedrich |
Pls do not merge yet. |
This PR would actually change the behavior of the binding. As of now you can use HSBType for RGB and a PercentType for the W channel. I think it is useful to bring in the conversion from RGBW which merges RGB and W into HSBType - but users should be able to select both the old and the proposed handling. I am thinking of using a custom DPT like 251.60600. I already have a draft for this, give me some time to check. |
I added the tag "won't fix", even if not really appropriate, to avoid a merge. |
Done with #16078 |
With the new feature, the HSBType is converted into RGBW, and we convert the status signal from the KNX back into an HSB value.
Due to the conversion, some accuracy is lost, but the result is approximately correct.
Need #openhab/openhab-core#3849 to work.