Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Fix brightness #15751

Merged
merged 3 commits into from
Oct 15, 2023
Merged

[http] Fix brightness #15751

merged 3 commits into from
Oct 15, 2023

Conversation

constambeys
Copy link
Contributor

No description provided.

@constambeys constambeys requested a review from a team as a code owner October 14, 2023 11:06
@jlaur jlaur changed the title fix brightness [http] Fix brightness Oct 14, 2023
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Oct 14, 2023
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

Please sign-off properly your PR.

@constambeys
Copy link
Contributor Author

Please sign-off properly your PR.

Is it ok now?

@lolodomo
Copy link
Contributor

Is it ok now?

No !

But as this is a very small change and as the change is obviously needed, I am going to merge your PR.

@lolodomo lolodomo merged commit d2b3f68 into openhab:main Oct 15, 2023
@lolodomo lolodomo added this to the 4.1 milestone Oct 15, 2023
@constambeys
Copy link
Contributor Author

Perfect, thanks 👍

querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
* [http] Fix brightness

---------

Signed-off-by: Timotheos Constambeys <timo0190@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
* [http] Fix brightness

---------

Signed-off-by: Timotheos Constambeys <timo0190@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [http] Fix brightness

---------

Signed-off-by: Timotheos Constambeys <timo0190@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants