Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve javadoc for some addons #15701

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Improve javadoc for some addons #15701

merged 5 commits into from
Oct 7, 2023

Conversation

holgerfriedrich
Copy link
Member

Follow-up of #15667.

Fixes javadoc issues not yet handled in #15667:

  • "invalid html" (due to special characters in javadoc)
  • invalid tags
  • some broken links
  • introduce custom tags @ implNote and @ apiNote on top level (previously only available in knx addon)

@holgerfriedrich
Improve javadoc for some addons
828cf58 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
hmerk
hmerk approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ekey, intesis and wemo

@holgerfriedrich
review comment
e117fdb 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
marcelrv
marcelrv approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@marcelrv marcelrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM max,windcentrale

MrRonfo
MrRonfo approved these changes Oct 6, 2023
View reviewed changes
Copy link

@MrRonfo MrRonfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for bticinosmarther binding, thanks

@holgerfriedrich
review comment
1e466b3 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@daMihe
Copy link
Contributor

daMihe commented Oct 6, 2023

LGTM for icalendar

morph166955
morph166955 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@morph166955 morph166955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for neeo

stefanroellin
stefanroellin requested changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@stefanroellin stefanroellin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links in the Pilight binding are no longer valid. Can you replace them with
https://manual.pilight.org/development/socket/index.html

...org.openhab.binding.pilight/src/main/java/org/openhab/binding/pilight/internal/dto/Code.java Outdated Show resolved Hide resolved
...g.openhab.binding.pilight/src/main/java/org/openhab/binding/pilight/internal/dto/Config.java Outdated Show resolved Hide resolved
....openhab.binding.pilight/src/main/java/org/openhab/binding/pilight/internal/dto/Version.java Outdated Show resolved Hide resolved
david-pace
david-pace requested changes Oct 7, 2023
View reviewed changes
Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one invalid Javadoc link

...ng.boschshc/src/main/java/org/openhab/binding/boschshc/internal/devices/BoschSHCHandler.java Outdated Show resolved Hide resolved
@holgerfriedrich
review comments
db1b3a3 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
remove email addresses from @author tag as requested
715cce2 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
david-pace
david-pace approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for boschshc, thanks 👍

jlaur
jlaur approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care! 👍

@jlaur jlaur merged commit f24a430 into openhab:main Oct 7, 2023
@jlaur jlaur added this to the 4.1 milestone Oct 7, 2023
@holgerfriedrich holgerfriedrich deleted the pr-sat2 branch October 8, 2023 03:34
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@holgerfriedrich @pat-git023
Improve javadoc for some addons (openhab#15701)
65210dd 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@holgerfriedrich @querdenker2k
Improve javadoc for some addons (openhab#15701)
8a06cb1 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@holgerfriedrich @querdenker2k
Improve javadoc for some addons (openhab#15701)
8f335f2 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@holgerfriedrich @austvik
Improve javadoc for some addons (openhab#15701)
b94dd8c 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
@jlaur jlaur mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel left review comments

@stefanroellin stefanroellin stefanroellin requested changes

@Jamstah Jamstah Jamstah approved these changes

@andrewfg andrewfg andrewfg approved these changes

@hmerk hmerk hmerk approved these changes

@marcelrv marcelrv marcelrv approved these changes

@david-pace david-pace david-pace approved these changes

@theater theater theater approved these changes

@jlaur jlaur jlaur approved these changes

@MrRonfo MrRonfo MrRonfo approved these changes

@morph166955 morph166955 morph166955 approved these changes

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@andylintner andylintner Awaiting requested review from andylintner andylintner is a code owner

@ccutrer ccutrer Awaiting requested review from ccutrer ccutrer is a code owner

@yfre yfre Awaiting requested review from yfre yfre is a code owner

@miloit miloit Awaiting requested review from miloit miloit is a code owner

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

@wborn wborn Awaiting requested review from wborn wborn is a code owner

@grro grro Awaiting requested review from grro grro is a code owner

@gs4711 gs4711 Awaiting requested review from gs4711 gs4711 is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@roieg roieg Awaiting requested review from roieg roieg is a code owner

@mlobstein mlobstein Awaiting requested review from mlobstein mlobstein is a code owner

@nokyyz nokyyz Awaiting requested review from nokyyz nokyyz is a code owner

@olivierkeke olivierkeke Awaiting requested review from olivierkeke olivierkeke is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@seime seime Awaiting requested review from seime seime is a code owner

@itb3 itb3 Awaiting requested review from itb3 itb3 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@reyem reyem Awaiting requested review from reyem reyem is a code owner

@martinvw martinvw Awaiting requested review from martinvw martinvw is a code owner

@appzer appzer Awaiting requested review from appzer appzer is a code owner

@Stratehm Stratehm Awaiting requested review from Stratehm Stratehm is a code owner

@niklasdoerfler niklasdoerfler Awaiting requested review from niklasdoerfler niklasdoerfler is a code owner

@CrackerStealth CrackerStealth Awaiting requested review from CrackerStealth CrackerStealth is a code owner

@FlorianSW FlorianSW Awaiting requested review from FlorianSW FlorianSW is a code owner

@psmedley psmedley Awaiting requested review from psmedley psmedley is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@weymann weymann Awaiting requested review from weymann weymann is a code owner

@ntruchsess ntruchsess Awaiting requested review from ntruchsess ntruchsess is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@sgiehl sgiehl Awaiting requested review from sgiehl sgiehl is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@syphr42 syphr42 Awaiting requested review from syphr42 syphr42 is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@Markinus Markinus Awaiting requested review from Markinus Markinus is a code owner

@robnielsen robnielsen Awaiting requested review from robnielsen

@daMihe daMihe Awaiting requested review from daMihe

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 is a code owner

@ramack ramack Awaiting requested review from ramack ramack is a code owner

@paphko paphko Awaiting requested review from paphko paphko is a code owner

@trokohl trokohl Awaiting requested review from trokohl trokohl is a code owner

@Andy2003 Andy2003 Awaiting requested review from Andy2003 Andy2003 is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@tratho tratho Awaiting requested review from tratho tratho is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@jofleck jofleck Awaiting requested review from jofleck jofleck is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@billfor billfor Awaiting requested review from billfor billfor is a code owner

@3cky 3cky Awaiting requested review from 3cky 3cky is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

@jimtng jimtng Awaiting requested review from jimtng jimtng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.