[tibber] Add channel for lastMeterProduction

[kjoglum]

Adding requested channel for lastMeterProduction, part of live measurements.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tibber-binding/67019/214

[lsiepel]

If you can fix the space, otherwise LGTM

[jlaur]

Thanks! LGTM. Besides @lsiepel's comment, please also add an update instruction for the new channel. See for example #14572. This will ensure that the channel is automatically added for managed things when upgrading to the new version without a need to recreate thing.

[jlaur]

This channel was added already in 3.4: #13416. I'm not sure what will happen when adding channels that already exists.

If nothing bad will happen, in principle one could just add all channels here to "play it safe". If a user would upgrade straight from 3.3 to 4.0, the instruction above would actually help.

But in this case we wouldn't need the update instructions for "add-channel" at all (conceptually), since they could be added/updated from the thing definitions, and check/upgrade simply triggered when thingTypeVersion is bumped.

@J-N-K - I could use some input here. The next question that will come up will be whether to bump thingTypeVersion per release, milestone or PR.

[kjoglum]

Being unaware of the update feature, I added the latest channels added believing to achieve what you describes wrt different version upgrades. Will update accordingly based on @J-N-K’s answer.

[kjoglum]

Going away for some days, so made the update instructions applicable only for the lastMeterProduction channel.

[J-N-K]

Don't add channels that could already be present, calling .withChannel on a ThingBuilder will result in an IllegalArgumentException when the channel is already present. You can use update, because removing a non-existing channel does not result in an error.

[jlaur]

LGTM