Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saic_ismart][wip] initial contribution of SAIC iSmart based vehicles #13573

Closed
wants to merge 33 commits into from

Conversation

tisoft
Copy link
Contributor

@tisoft tisoft commented Oct 20, 2022

Work in progress.

Supports reading out vehicle data of cars running the iSMART system from SAIC.
Currently tested against a MG5 2022.

The API itself is reverse engineered in this project: https://github.com/ReverseEngineeringDE/SAIC-API-Documentation/

If you use this plugin, the iSmart iOS/Android app will be disconnected, since only one login session is supported by the API.

Currently you need to use the official iSmart app to register an account and bind your vehicle.

You should activate "Engine Start Messages" in the iSmart App. The plugin only queries the car while it is running or charging (That is when the HV battery is powered on). This setting will send a message over the API, every time the car is started, so the plugin can detect that without querying the car. This helps to protect from 12V-battery drainage. Additionally there is an advanced "Force refresh" channel, that can be used to manually force an update of the car data. The plugin will query the car 15 minutes after the last activity has been detected. So if you shutdown your engine and start charging within 15 Minutes, the plugin will stay active and display charging data. If you need more than 15 minutes, the charging will not be detected.

  • Get vehicle Data
    • Location
    • Speed
    • Mileage
    • SOC
    • Temperatures
    • Door State
    • Window State (if supported by car)
    • Tyre Pressure
    • Charge State
    • current power usage
    • auxiliary battery voltage
    • Display car messages
    • accumulated power usage ❓
    • SOH ❓
  • Control vehicle
    • Remote Climate Control 🚧
    • (Un-)Lock
    • Locate Car (Light/Honk)
    • Window Control (if supported by car)
  • Generic Features
    • Relogin after logout/token expiration
    • Automatically register for all alarm/car messages
    • Configure available channels based on car capabilities
    • Display account messages
    • Send data to A better Routeplanner (optional)

❓: It is currently unknown if this feature is possible
🚧: Feature is currently WIP, use with caution

This plugin can drain your 12v battery! it is not yet optimized for power saving!
This should be fixed. I have the plugin running for quite some time and the 12V battery is fine. But please check this regularly.

Download: https://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.saicismart/3.4.1-SNAPSHOT/org.openhab.binding.saicismart-3.4.1-SNAPSHOT.jar

@lolodomo lolodomo added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Oct 20, 2022
@tisoft tisoft force-pushed the saic_api branch 3 times, most recently from 072c406 to e674649 Compare October 20, 2022 07:42
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-binding-integration-of-saic-mg-ismart-based-vehicles/140136/1

@tisoft tisoft force-pushed the saic_api branch 4 times, most recently from f240712 to 39ad0b8 Compare October 29, 2022 16:10
@tisoft tisoft marked this pull request as ready for review December 15, 2022 10:25
@tisoft tisoft requested a review from a team as a code owner December 15, 2022 10:25
@tisoft
Copy link
Contributor Author

tisoft commented Dec 15, 2022

This is not complete, yet. But I would like some in between review, to see if I am going in the right direction.

@tisoft tisoft force-pushed the saic_api branch 6 times, most recently from b6f75b4 to 0a9cb20 Compare December 19, 2022 07:57
@tisoft tisoft changed the base branch from main to 3.4.x December 22, 2022 21:11
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be adapted to the new addon.xml, the PR to adapt the developer docs is not merged yet, so if you need more details, the corresponding issue is here: openhab/openhab-core#2058
But you can also update your branch and look at another binding's addon.xml and adapt it to this initial contribution.

@jlaur
Copy link
Contributor

jlaur commented Mar 11, 2023

Please create a new PR targeting the main branch.

@jlaur jlaur closed this Mar 11, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-binding-integration-of-saic-mg-ismart-based-vehicles/140136/23

dougculnane added a commit to dougculnane/openhab-addons that referenced this pull request Nov 8, 2023
Signed-off-by: dougculnane <doug@culnane.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants