Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goecharger] Add powerAll to thing-types #12742

Merged
merged 3 commits into from
May 16, 2022

Conversation

ranzen84
Copy link
Contributor

Fixes #12735

Signed-off-by: Reinhard Plaim reinhardplaim@gmail.com

Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This channel was already documented so nothing to add.
You just have to update the default translations file.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 15, 2022
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
@ranzen84 ranzen84 requested a review from lolodomo May 16, 2022 06:53
Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit e7f20b4 into openhab:main May 16, 2022
@lolodomo lolodomo added this to the 3.3 milestone May 16, 2022
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [goecharger] Add powerAll to thing-types

Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [goecharger] Add powerAll to thing-types

Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [goecharger] Add powerAll to thing-types

Signed-off-by: Reinhard Plaim <reinhardplaim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[goecharger] Power_All missing but should be there
2 participants