Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miele] Consolidate properties for compliance #11997

Merged
merged 1 commit into from
Jan 8, 2022
Merged

[miele] Consolidate properties for compliance #11997

merged 1 commit into from
Jan 8, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 8, 2022 •
edited
Loading

Fixes #11996

Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk

This pull request provides minor changes for property improvements:

  • modelId renamed from model.
  • vendor introduced.
  • firmwareVersion introduced.
  • connectionBaudRate introduced.

@jlaur
Consolidate properties for compliance.
48bbe88 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from kgoderis as a code owner January 8, 2022 09:47
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 8, 2022
@jlaur jlaur requested a review from lolodomo January 8, 2022 09:48
lolodomo
lolodomo approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 56a10af into openhab:main Jan 8, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 8, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@jlaur @mischmidt83
Consolidate properties for compliance. (openhab#11997)
c5dbbc7 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@jlaur @moesterheld
Consolidate properties for compliance. (openhab#11997)
b398886 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@jlaur
Consolidate properties for compliance. (openhab#11997)
e07b7f3 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@jlaur @NickWaterton
Consolidate properties for compliance. (openhab#11997)
a2cc832 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur deleted the 11996-miele-properties branch May 25, 2022 21:22
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@jlaur @andan67
Consolidate properties for compliance. (openhab#11997)
1c88350 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@jlaur @andrasU
Consolidate properties for compliance. (openhab#11997)
e052dc6 
Fixes openhab#11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[miele] Consolidate properties
2 participants
@jlaur @lolodomo