Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homematic] fixing incorrect scan duration after openHAB restart #11971

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[homematic] fixing incorrect scan duration after openHAB restart #11971

merged 1 commit into from
Jan 7, 2022

Conversation

raykleibelt
Copy link
Contributor

Bug fix for #11969

Issue:

After restart of openHAB the scan duration for homematic devices is read from a variable which is initialized with a default value instead of using the configuration of the binding.

Fix:

The scan duration is read directly from the configuration of the binding.

@raykleibelt raykleibelt requested a review from gerrieg as a code owner January 5, 2022 20:39
@raykleibelt
Update HomematicDeviceDiscoveryService.java
dc7c881 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 7, 2022
@jlaur jlaur linked an issue Jan 7, 2022 that may be closed by this pull request
[homematic] some devices offline (CONFIGURATION_ERROR) after restart of openHAB when using large number of homematic devices #11969
Closed
lolodomo
lolodomo approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 6500264 into openhab:main Jan 7, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 7, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@raykleibelt @mischmidt83
Update HomematicDeviceDiscoveryService.java (openhab#11971)
39d35b4 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
@raykleibelt raykleibelt deleted the patch-1 branch January 10, 2022 16:38
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@raykleibelt @moesterheld
Update HomematicDeviceDiscoveryService.java (openhab#11971)
f76d329 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@raykleibelt
Update HomematicDeviceDiscoveryService.java (openhab#11971)
efdb833 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@raykleibelt @NickWaterton
Update HomematicDeviceDiscoveryService.java (openhab#11971)
df9da51 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@raykleibelt @andan67
Update HomematicDeviceDiscoveryService.java (openhab#11971)
9f8e90a 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@raykleibelt @andrasU
Update HomematicDeviceDiscoveryService.java (openhab#11971)
6ff0bb5 
fix for bug openhab#11969

After a restart of openHAB the function 'getScanTimeout()' is called before the member 'installModeDuration' has been initialized with the correct value from the configuration. With a large number of Homematic devices, the default value of 'installModeDuration' is too small to read in all Homematic devices from the CCU.
Therefore, when calling the function 'getScanTimeout()', the value is read directly from the configuration. The member 'installModeDuration' has been removed.

Signed-off-by: raykleibelt <54982000+raykleibelt@users.noreply.github.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@gerrieg gerrieg Awaiting requested review from gerrieg

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.3
3 participants
@raykleibelt @lolodomo @jlaur