Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid UnsupportedEncodingException & use const from StandardCharsets #11948

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Avoid UnsupportedEncodingException & use const from StandardCharsets #11948

merged 1 commit into from
Jan 3, 2022

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Jan 3, 2022 •
edited
Loading

  • Avoid UnsupportedEncodingException & use const from StandardCharsets

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp
Avoid UnsupportedEncodingException & use const from StandardCharsets
830d2e6 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp force-pushed the feature-remove-unsupportedencodingexception branch from 37056c7 to 830d2e6 Compare January 3, 2022 11:05
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jan 3, 2022
mhilbush
mhilbush approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@mhilbush mhilbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigAssFan, GlobalCache, Squeezebox, and ZoneMinder LGTM

Thanks for the improvements

wborn
wborn approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this big cleanup! 👍

octa22
octa22 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@octa22 octa22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@wborn wborn merged commit 167f8eb into openhab:main Jan 3, 2022
@wborn wborn added this to the 3.3 milestone Jan 3, 2022
@cweitkamp cweitkamp deleted the feature-remove-unsupportedencodingexception branch January 3, 2022 15:08
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@cweitkamp @mischmidt83
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
48e82da 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@cweitkamp @moesterheld
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
4839767 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@cweitkamp
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
2c45629 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@cweitkamp @NickWaterton
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
e98d348 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@cweitkamp @andan67
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
88f076b 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@cweitkamp @andrasU
Avoid UnsupportedEncodingException & use const from StandardCharsets (o…
ccf0da0 
…penhab#11948)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@mhilbush mhilbush mhilbush approved these changes

@octa22 octa22 octa22 approved these changes

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@Cossey Cossey Awaiting requested review from Cossey Cossey is a code owner

@cschneider cschneider Awaiting requested review from cschneider cschneider is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@FlorianSW FlorianSW Awaiting requested review from FlorianSW FlorianSW is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@JochenHiller JochenHiller Awaiting requested review from JochenHiller

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@Nebula83 Nebula83 Awaiting requested review from Nebula83 Nebula83 is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@pdegeus pdegeus Awaiting requested review from pdegeus

@ppieczul ppieczul Awaiting requested review from ppieczul ppieczul is a code owner

@reyem reyem Awaiting requested review from reyem reyem is a code owner

@RSStephens RSStephens Awaiting requested review from RSStephens RSStephens is a code owner

@Skinah Skinah Awaiting requested review from Skinah Skinah is a code owner

@tmrobert8 tmrobert8 Awaiting requested review from tmrobert8

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@cweitkamp @wborn @mhilbush @octa22 @lolodomo