Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yamahamusiccast] Initial contribution #11880

Merged
merged 9 commits into from
Jan 6, 2022
Merged

[yamahamusiccast] Initial contribution #11880

merged 9 commits into from
Jan 6, 2022

Conversation

coop-git
Copy link
Contributor

Binding to integrate Yamaha devices based on their YamahaMusiccast protocol/API
Development started in 2020 and binding hasn't changed in the last months.
It is running stable and no recent changes were made.
This is the second PR as I had to abandon the previous one due to time constraints.
Code is signed and the build did not generate errors or warnings.

With this binding users are able to use their Yamaha (sound) devices and link them in groups to play together in a multi room setup.
Thread in Community where the whole history can be found.
This thread also shows on what devices it has been tested.

coop-git and others added 2 commits December 29, 2021 10:22
@coop-git
Pull Request OH3
e093249 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Merge branch 'openhab:main' into main
b5aabf3
@coop-git coop-git requested a review from a team as a code owner December 29, 2021 09:48
@coop-git
Pull Request OH3
c68bc3e 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Pull Request OH3
f36b21a 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Pull Request OH3
7d0a2a1 
Signed-off-by: Lennert Coopman <github@coopman.org>
@lolodomo lolodomo added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 29, 2021
@fwolter
Copy link
Member

fwolter commented Jan 1, 2022

Did you incorporate all review feedback from #9658?

@coop-git
Copy link
Contributor Author

coop-git commented Jan 2, 2022

I should have done it: removed unused variables and methods, most logging is set to debug, compiling did not return errors or warnings, added local variables to avoid null occurences.
As the compiler is running more extensive checks than before and none were now returned, I think I solved all.

fwolter
fwolter requested changes Jan 3, 2022
View reviewed changes
@coop-git
Pull Request OH3
e5fd617 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Pull Request OH3
72e299a 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Pull Request OH3
9c46ecc 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git
Pull Request OH3
16c68cf 
Signed-off-by: Lennert Coopman <github@coopman.org>
@coop-git coop-git requested a review from fwolter January 3, 2022 21:51
fwolter
fwolter reviewed Jan 6, 2022
View reviewed changes
...ccast/src/main/java/org/openhab/binding/yamahamusiccast/internal/YamahaMusiccastHandler.java
logger.debug("setServerInfo json: {}", json);
logger.trace("setServerInfo json: {}", json);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't dump json data into the logs in the future. You could use the debugger during development or add these dumps to dedicated JARs for certain users if they encounter some problems.

fwolter
fwolter approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@fwolter fwolter merged commit 60c1ece into openhab:main Jan 6, 2022
@fwolter fwolter added this to the 3.3 milestone Jan 6, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/yamaha-musiccast-binding-revival/57833/383

@coop-git coop-git mentioned this pull request Jan 6, 2022
Merged
Confectrician pushed a commit to openhab/openhab-docs that referenced this pull request Jan 6, 2022
@coop-git
Add files via upload (#1723)
07dc58f 
Logo for binding, see openhab/openhab-addons#11880
@fwolter
Copy link
Member

fwolter commented Jan 6, 2022

Can you please file another PR and add the NOTICE file? See https://github.com/openhab/openhab-addons/pull/11239/files#diff-76f6974e5bf2cbae21a89c0a3d6494bb13b1107e5e4d7fac19b554d1e51f2ef4 for example.

@coop-git coop-git mentioned this pull request Jan 6, 2022
Merged
@coop-git
Copy link
Contributor Author

coop-git commented Jan 6, 2022

Done, see PR 11978

@lolodomo
Copy link
Contributor

lolodomo commented Jan 9, 2022

Please create a subsequent PR to add the default translation properties file.
You can produce it simply by running this command : mvn i18n:generate-default-translations

mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@coop-git @mischmidt83
[yamahamusiccast] Initial contribution (openhab#11880)
2e68a3f 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
@coop-git
Copy link
Contributor Author

I'm getting this error:
No plugin found for prefix 'i18n' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (...), central (https://repo1.maven.org/maven2), openhab-release (https://openhab.jfrog.io/openhab/libs-release)] -> [Help 1]
Tried to find out what it is but no luck so far. Any tip welcome. Thanks

moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@coop-git @moesterheld
[yamahamusiccast] Initial contribution (openhab#11880)
e516d2f 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@coop-git
[yamahamusiccast] Initial contribution (openhab#11880)
54074fb 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@coop-git @NickWaterton
[yamahamusiccast] Initial contribution (openhab#11880)
d2142e7 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@hmerk hmerk mentioned this pull request Jun 28, 2022
Closed
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@coop-git @andan67
[yamahamusiccast] Initial contribution (openhab#11880)
dc4592d 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@coop-git @andrasU
[yamahamusiccast] Initial contribution (openhab#11880)
1bfdff5 
* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>

* Pull Request OH3

Signed-off-by: Lennert Coopman <github@coopman.org>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@coop-git @fwolter @openhab-bot @lolodomo