Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dscalarm] Update README.md #11862

Merged
merged 1 commit into from
Jan 6, 2022
Merged

[dscalarm] Update README.md #11862

merged 1 commit into from
Jan 6, 2022

Conversation

yfaway
Copy link
Contributor

@yfaway yfaway commented Dec 26, 2021

Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.

Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
@yfaway yfaway requested a review from RSStephens as a code owner December 26, 2021 22:24
@Confectrician Confectrician changed the title Update README.md [dscalarm] Update README.md Dec 27, 2021
@lolodomo
Copy link
Contributor

@RSStephens for review

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, your changes are correct but you missed two channels which are writtable too: zone_bypass_mode and panel_command. This second channel is apparently even not documented at all.
Can you also fix that?

@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2022

Can you also fix that?

Could be done in a next PR. You are welcome to do it.

I am going to merge this proposal.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Jan 6, 2022

Not correctly signed off but it is only a minor change in the documentation.

@lolodomo lolodomo merged commit 3c78ddf into openhab:main Jan 6, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 6, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.

Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.

Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.

Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants