-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dscalarm] Update README.md #11862
[dscalarm] Update README.md #11862
Conversation
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
@RSStephens for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, your changes are correct but you missed two channels which are writtable too: zone_bypass_mode and panel_command. This second channel is apparently even not documented at all.
Can you also fix that?
Could be done in a next PR. You are welcome to do it. I am going to merge this proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not correctly signed off but it is only a minor change in the documentation. |
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands. Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands. Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands. Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Fix 1 spelling error. Mark several channels as writable. Add link to the PDF file that contains the list of EnvisaLink commands.