Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default translations for io add-ons #11753

Merged
merged 2 commits into from
Dec 12, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 11, 2021

This makes the texts used by these add-ons translatable with Crowdin.

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Contributor

@yfre yfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for homekit

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is nothing for the ImperiHome integration service.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Member Author

wborn commented Dec 11, 2021

Note that there is nothing for the ImperiHome integration service.

It doesn't seem to have any configuration parameters:

https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.io.imperihome/src/main/resources/OH-INF/config/config.xml

But it is a configurable service:

@ConfigurableService(category = "io", label = "ImperiHome Integration", description_uri = "io:imperihome")

Looks like it can all be removed and readded when neccessary in the future?

@lolodomo
Copy link
Contributor

Ok, so we can probably forget Imperihome.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 12, 2021
@lolodomo lolodomo merged commit e752b51 into openhab:main Dec 12, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 12, 2021
@wborn wborn deleted the translatable-io-addons branch December 12, 2021 18:33
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants