-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amplipi] Add discovery and PA support #11586
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@linknum23 FYI! |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this nice enhancement!
It looked like a lot of code but most of it is generated. 😉
I only have one small remark and also a question.
...ab.binding.amplipi/src/main/java/org/openhab/binding/amplipi/internal/audio/PAAudioSink.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Thanks @wborn, your remarks are addressed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
This PR adds the possibility to find the AmpliPi on the local network through mDNS.
Additionally, it now acts as an audio sink, so that audio streams can be sent to it, which are then announced as a PA on all available zones (either with current volume or a specified volume level). This is a great feature for doing announcements in every room, such as doorbell, telephone call notifications etc.
Signed-off-by: Kai Kreuzer kai@openhab.org