[js-transform] Inline java script support #11473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
|
Recently written lot of java script transformation rules and file based broach is not very handy for simple script where input is just e.g. dived by 100. This introduce inline possibility where script can be directly given without writing dedicated java script file. Some earlier discussion eclipse-archived/smarthome#4318 |
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
|
@openhab/add-ons-maintainers as this is rather simple PR and no comments so far, so is there some kind of hesitation to accept this PR? |
|
I've never been in touch with JavaScript and OH. That's why I didn't approve it. Maybe @wborn can take a look. |
kaikreuzer
approved these changes
Dec 12, 2021
bundles/org.openhab.transform.javascript/src/main/resources/OH-INF/config/javascriptProfile.xml
Outdated
Show resolved
Hide resolved
…-INF/config/javascriptProfile.xml
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [js-transform] inline java script support Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pauli Anttila pauli.anttila@gmail.com